completed hacktoberfest 2019

Published on

this year i participated again in the hacktoberfest, and it’s been fun!

i had half a month to actually complete the challenge (to have 4 pull requests merged and approved), since i was on vacation 🌍 🏖.

contributions

/assets/images/posts/completed-hacktoberfest-2019/contributions.png

clio-lang

a simple renaming of a method got me this merged.

i noticed this naming could be improved, as star and transform are two separate names and should be separated by _.

e.g.

-    startransform: function(node) {
+ star_transform: function(node) {

problem-solving-javascript

added tests for bottom view binary tree

e.g.

+    const BinaryTree = require("../index");
+ const bottomView = require('.');
+
+ describe('Bottom View Binary Tree', () => {
+ let btree
+
+ beforeEach(() => {
+ btree = new BinaryTree([1, 2, 3, 4, 5, 6]);
+ });
+
+ it('Should determine the bottom view of a binary tree', () => {
+ expect(bottomView(btree)).toEqual([6, 2, 3, 4]);
+ });
+ it('Should handle null binary tree', () => {
+ expect(bottomView(null)).toEqual([]);
+ });
+ });

m.args

this should help with unifying the readme to other m.projects

m.static

this pr updates the badges in the readme

/assets/images/posts/completed-hacktoberfest-2019/congratulations.png

another year, another hacktoberfest

did you participate this year? let me know @devcri